#pragma semicolon 1 #pragma newdecls required #define PLUGIN_NAME "[L4D1/2] Survivor Identity Fix for 5+ Survivors" #define PLUGIN_AUTHOR "Merudo, Shadowysn" #define PLUGIN_DESC "Fix bug where a survivor will change identity when a player connects/disconnects if there are 5+ survivors" #define PLUGIN_VERSION "1.6" #define PLUGIN_URL "https://forums.alliedmods.net/showthread.php?p=2403731#post2403731" #define PLUGIN_NAME_SHORT "5+ Survivor Identity Fix" #define PLUGIN_NAME_TECH "survivor_identity_fix" #include #include #include #include #define TEAM_SURVIVOR 2 #define TEAM_PASSING 4 char g_Models[MAXPLAYERS+1][128]; int g_iPendingCookieModel[MAXPLAYERS+1]; #define GAMEDATA "l4d_survivor_identity_fix" Handle hConf = null; #define NAME_SetModel "CBasePlayer::SetModel" static Handle hDHookSetModel = null, hModelPrefCookie; static ConVar hCookiesEnabled; static bool isLateLoad, cookieModelsSet; static int survivors; #define SIG_SetModel_LINUX "@_ZN11CBasePlayer8SetModelEPKc" #define SIG_SetModel_WINDOWS "\\x55\\x8B\\x2A\\x8B\\x2A\\x2A\\x56\\x57\\x50\\x8B\\x2A\\xE8\\x2A\\x2A\\x2A\\x2A\\x8B\\x2A\\x2A\\x2A\\x2A\\x2A\\x8B\\x2A\\x8B\\x2A\\x2A\\x8B" #define SIG_L4D1SetModel_WINDOWS "\\x8B\\x2A\\x2A\\x2A\\x56\\x57\\x50\\x8B\\x2A\\xE8\\x2A\\x2A\\x2A\\x2A\\x8B\\x3D" //TODO: Setup cookies public Plugin myinfo = { name = PLUGIN_NAME, author = PLUGIN_AUTHOR, description = PLUGIN_DESC, version = PLUGIN_VERSION, url = PLUGIN_URL } public APLRes AskPluginLoad2(Handle myself, bool late, char[] error, int err_max) { CreateNative("IdentityFix_SetPlayerModel", Native_SetPlayerModel); if(late) isLateLoad = true; return APLRes_Success; } public void OnPluginStart() { GetGamedata(); CreateConVar("l4d_survivor_identity_fix_version", PLUGIN_VERSION, "Survivor Change Fix Version", FCVAR_SPONLY|FCVAR_NOTIFY|FCVAR_DONTRECORD); hCookiesEnabled = CreateConVar("l4d_survivor_identity_fix_cookies", "1.0", "0 -> Disable cookie preference, 1 -> Enable for 5+, 2 -> Enable for any amount"); HookEvent("player_bot_replace", Event_PlayerToBot, EventHookMode_Post); HookEvent("bot_player_replace", Event_BotToPlayer, EventHookMode_Post); HookEvent("game_newmap", Event_NewGame); HookEvent("player_first_spawn", Event_PlayerFirstSpawn); HookEvent("player_disconnect", Event_PlayerDisconnect); HookEvent("finale_start", Event_FinaleStart); if(isLateLoad) { for(int i = 1; i <= MaxClients; i++) { if(IsClientConnected(i) && IsClientInGame(i) && IsPlayerAlive(i) && IsSurvivor(i)) GetClientModel(i, g_Models[i], 64); //TODO: Convert ^ to ID } } hModelPrefCookie = RegClientCookie("survivor_model", "Survivor model preference", CookieAccess_Public); } // ------------------------------------------------------------------------ // Stores the client of each survivor each time it is changed // Needed because when Event_PlayerToBot fires, it's hunter model instead // ------------------------------------------------------------------------ public MRESReturn SetModel_Pre(int client, Handle hParams) { } // We need this pre hook even though it's empty, or else the post hook will crash the game. public MRESReturn SetModel(int client, Handle hParams) { if (!IsValidClient(client)) return; if (!IsSurvivor(client)) { g_Models[client][0] = '\0'; return; } char model[128]; DHookGetParamString(hParams, 1, model, sizeof(model)); if (StrContains(model, "models/infected", false) < 0) { strcopy(g_Models[client], 128, model); } } // ------------------------------------------------------------------------ // Models & survivor names so bots can be renamed // ------------------------------------------------------------------------ char survivor_names[8][] = { "Nick", "Rochelle", "Coach", "Ellis", "Bill", "Zoey", "Francis", "Louis"}; char survivor_models[8][] = { "models/survivors/survivor_gambler.mdl", "models/survivors/survivor_producer.mdl", "models/survivors/survivor_coach.mdl", "models/survivors/survivor_mechanic.mdl", "models/survivors/survivor_namvet.mdl", "models/survivors/survivor_teenangst.mdl", "models/survivors/survivor_biker.mdl", "models/survivors/survivor_manager.mdl" }; // -------------------------------------- // Bot replaced by player // -------------------------------------- public Action Event_BotToPlayer(Handle event, const char[] name, bool dontBroadcast) { int player = GetClientOfUserId(GetEventInt(event, "player")); int bot = GetClientOfUserId(GetEventInt(event, "bot")); if (!IsValidClient(player) || !IsSurvivor(player) || IsFakeClient(player)) return; // ignore fake players (side product of creating bots) char model[128]; GetClientModel(bot, model, sizeof(model)); SetEntityModel(player, model); strcopy(g_Models[player], 64, model); SetEntProp(player, Prop_Send, "m_survivorCharacter", GetEntProp(bot, Prop_Send, "m_survivorCharacter")); } // -------------------------------------- // Player -> Bot // -------------------------------------- public Action Event_PlayerToBot(Handle event, char[] name, bool dontBroadcast) { int player = GetClientOfUserId(GetEventInt(event, "player")); int bot = GetClientOfUserId(GetEventInt(event, "bot")); if (!IsValidClient(player) || !IsSurvivor(player) || IsFakeClient(player)) return; // ignore fake players (side product of creating bots) if (g_Models[player][0] != '\0') { int playerType = GetEntProp(player, Prop_Send, "m_survivorCharacter"); SetEntProp(bot, Prop_Send, "m_survivorCharacter", playerType); SetEntityModel(bot, g_Models[player]); // Restore saved model. Player model is hunter at this point SetClientInfo(bot, "name", survivor_names[playerType]); } } void GetGamedata() { char filePath[PLATFORM_MAX_PATH]; BuildPath(Path_SM, filePath, sizeof(filePath), "gamedata/%s.txt", GAMEDATA); if( FileExists(filePath) ) { hConf = LoadGameConfigFile(GAMEDATA); // For some reason this doesn't return null even for invalid files, so check they exist first. } else { PrintToServer("[SM] %s plugin unable to get %i.txt gamedata file. Generating...", PLUGIN_NAME_SHORT, GAMEDATA); Handle fileHandle = OpenFile(filePath, "a+"); if (fileHandle == null) { SetFailState("[SM] Couldn't generate gamedata file!"); } WriteFileLine(fileHandle, "\"Games\""); WriteFileLine(fileHandle, "{"); WriteFileLine(fileHandle, " \"left4dead\""); WriteFileLine(fileHandle, " {"); WriteFileLine(fileHandle, " \"Signatures\""); WriteFileLine(fileHandle, " {"); WriteFileLine(fileHandle, " \"%s\"", NAME_SetModel); WriteFileLine(fileHandle, " {"); WriteFileLine(fileHandle, " \"library\" \"server\""); WriteFileLine(fileHandle, " \"linux\" \"%s\"", SIG_SetModel_LINUX); WriteFileLine(fileHandle, " \"windows\" \"%s\"", SIG_L4D1SetModel_WINDOWS); WriteFileLine(fileHandle, " \"mac\" \"%s\"", SIG_SetModel_LINUX); WriteFileLine(fileHandle, " }"); WriteFileLine(fileHandle, " }"); WriteFileLine(fileHandle, " }"); WriteFileLine(fileHandle, " \"left4dead2\""); WriteFileLine(fileHandle, " {"); WriteFileLine(fileHandle, " \"Signatures\""); WriteFileLine(fileHandle, " {"); WriteFileLine(fileHandle, " \"%s\"", NAME_SetModel); WriteFileLine(fileHandle, " {"); WriteFileLine(fileHandle, " \"library\" \"server\""); WriteFileLine(fileHandle, " \"linux\" \"%s\"", SIG_SetModel_LINUX); WriteFileLine(fileHandle, " \"windows\" \"%s\"", SIG_SetModel_WINDOWS); WriteFileLine(fileHandle, " \"mac\" \"%s\"", SIG_SetModel_LINUX); WriteFileLine(fileHandle, " }"); WriteFileLine(fileHandle, " }"); WriteFileLine(fileHandle, " }"); WriteFileLine(fileHandle, "}"); CloseHandle(fileHandle); hConf = LoadGameConfigFile(GAMEDATA); if (hConf == null) { SetFailState("[SM] Failed to load auto-generated gamedata file!"); } PrintToServer("[SM] %s successfully generated %s.txt gamedata file!", PLUGIN_NAME_SHORT, GAMEDATA); } PrepDHooks(); } //Reset the list of models on a new game -> no players. public void Event_NewGame(Event event, const char[] name, bool dontBroadcast) { PrintToServer("Clearing models"); for(int i = 1; i <= MaxClients; i++) { g_Models[i][0] = '\0'; } survivors = 0; cookieModelsSet = false; } //Checks if a user has a model preference cookie (set by native). If so, populate g_Models w/ it public void OnClientCookiesCached(int client) { if(IsFakeClient(client) && hCookiesEnabled.IntValue == 0) return; char modelPref[2]; GetClientCookie(client, hModelPrefCookie, modelPref, sizeof(modelPref)); if(strlen(modelPref) > 0) { int type = StringToInt(modelPref); if(type > 0 && type <= 8) { strcopy(g_Models[client], 64, survivor_models[type - 1]); g_iPendingCookieModel[client] = type; //A valid cookie was found, set their model. }else{ SetClientCookie(client, hModelPrefCookie, "0"); //Set to current model? } } } //Prevent issues with L4D1 characters being TP'd and stuck in brain dead form static bool IsTemporarilyL4D2[MAXPLAYERS]; //Use index 0 to state if its activated public void OnMapStart() { char map[16]; GetCurrentMap(map, sizeof(map)); if(StrEqual(map, "c6m3_port")) { HookEvent("door_open", Event_DoorOpen); } } public Action Event_DoorOpen(Event event, const char[] name, bool dontBroadcast) { for(int i = 1; i <= MaxClients; i++) { if(IsClientConnected(i) && IsClientInGame(i) && GetClientTeam(i) == 2) { int playerType = GetEntProp(i, Prop_Send, "m_survivorCharacter"); //If character is L4D1 Character (4: bill, etc..) then swap if(playerType > 3) { SetEntProp(i, Prop_Send, "m_survivorCharacter", playerType - 4); IsTemporarilyL4D2[i] = true; } } } IsTemporarilyL4D2[0] = true; UnhookEvent("door_open", Event_DoorOpen); } public void OnClientPutInServer(int client) { RequestFrame(Frame_PutInServer, client); } public void Frame_PutInServer(int client) { } //On finale start: Set back to their L4D1 character. public Action Event_FinaleStart(Event event, const char[] name, bool dontBroadcast) { if(IsTemporarilyL4D2[0]) { for(int i = 0; i <= MaxClients; i++) { if(i > 0 && IsClientConnected(i) && IsClientInGame(i) && GetClientTeam(i) == 2 && IsTemporarilyL4D2[i]) { int playerType = GetEntProp(i, Prop_Send, "m_survivorCharacter"); SetEntProp(i, Prop_Send, "m_survivorCharacter", playerType + 4); } IsTemporarilyL4D2[i] = false; } } } //Either use preferred model OR find the least-used. public Action Event_PlayerFirstSpawn(Event event, const char[] name, bool dontBroadcast) { int client = GetClientOfUserId(event.GetInt("userid")); if(IsFakeClient(client)) return; //Have to ignore bots for now, due to idle bots if(GetClientTeam(client) == 2) { //todo: hCookiesEnabled.IntVal if(++survivors > 4 && g_iPendingCookieModel[client] > 0) { //A model is set: Fetched from cookie if(!cookieModelsSet) { cookieModelsSet = true; CreateTimer(0.1, Timer_SetAllCookieModels); PrintToServer("Over 4 clients, setting models for all users based on cookie."); }else { PrintToServer("Client joined with model cookie | client %N | cookie %d", client, g_iPendingCookieModel[client]); RequestFrame(Frame_SetPlayerModel, client); } }else{ //Model was not set: Use least-used survivor. //RequestFrame(Frame_SetPlayerToLeastUsedModel, client); } } } public void Frame_SetPlayerModel(int client) { SetEntityModel(client, survivor_models[g_iPendingCookieModel[client] - 1]); SetEntProp(client, Prop_Send, "m_survivorCharacter", g_iPendingCookieModel[client] - 1); g_iPendingCookieModel[client] = 0; } public Action Timer_SetAllCookieModels(Handle h) { for(int i = 1; i <= MaxClients; i++) { if(IsClientConnected(i) && g_iPendingCookieModel[i] && GetClientTeam(i) == 2) { SetEntityModel(i, survivor_models[g_iPendingCookieModel[i] - 1]); SetEntProp(i, Prop_Send, "m_survivorCharacter", g_iPendingCookieModel[i] - 1); } g_iPendingCookieModel[i] = 0; } } public void Frame_SetPlayerToLeastUsedModel(int client) { int type = GetLeastUsedSurvivor(client) ; SetEntityModel(client, survivor_models[type]); SetEntProp(client, Prop_Send, "m_survivorCharacter", type); strcopy(g_Models[client], 64, survivor_models[type]); } public Action Event_PlayerDisconnect(Event event, const char[] name, bool dontBroadcast) { int client = GetClientOfUserId(event.GetInt("userid")); g_Models[client][0] = '\0'; survivors--; } void PrepDHooks() { if (hConf == null) { SetFailState("Error: Gamedata not found"); } hDHookSetModel = DHookCreateDetour(Address_Null, CallConv_THISCALL, ReturnType_Void, ThisPointer_CBaseEntity); DHookSetFromConf(hDHookSetModel, hConf, SDKConf_Signature, NAME_SetModel); DHookAddParam(hDHookSetModel, HookParamType_CharPtr); DHookEnableDetour(hDHookSetModel, false, SetModel_Pre); DHookEnableDetour(hDHookSetModel, true, SetModel); } bool IsValidClient(int client, bool replaycheck = true) { if (client <= 0 || client > MaxClients) return false; if (!IsClientInGame(client)) return false; if (replaycheck) { if (IsClientSourceTV(client) || IsClientReplay(client)) return false; } return true; } bool IsSurvivor(int client) { if (GetClientTeam(client) != TEAM_SURVIVOR && GetClientTeam(client) != TEAM_PASSING) return false; return true; } public int Native_SetPlayerModel(Handle plugin, int numParams) { int client = GetNativeCell(1); int character = GetNativeCell(2); bool keep = GetNativeCell(3) == 1; if(numParams != 2 && numParams != 3) { ThrowNativeError(SP_ERROR_NATIVE, "Incorrect amount of parameters passed"); return 3; }else if(client < 1 || client > MaxClients || !IsClientInGame(client)) { ThrowNativeError(SP_ERROR_INDEX, "Client index %d is not valid or is not in game", client); return 2; } else if(character < 0 || character > 7) { ThrowNativeError(SP_ERROR_INDEX, "Character ID (%d) is not in range (0-7)", character); return 1; } else { //Set a cookie to remember their model, starting at 1. char charTypeStr[2]; Format(charTypeStr, sizeof(charTypeStr), "%d", character + 1); if(!IsFakeClient(client) && keep) SetClientCookie(client, hModelPrefCookie, charTypeStr); strcopy(g_Models[client], 64, survivor_models[character]); return 0; } } stock int GetLeastUsedSurvivor(int client) { //TODO: Only work if > 5 int count[8], lowestID, players; for(int i = 1; i <= MaxClients; ++i) { if(IsClientConnected(i) && IsClientInGame(i) && GetClientTeam(i) == 2 && i != client) { count[GetSurvivorType(g_Models[i])]++; players++; } } //TODO: set starting number to be map-based. //int start = players > 4 for(int id = 0; id < 8; ++id) { if(count[id] == 0) { return id; }else if(count[id] < count[lowestID]) { lowestID = id; } } return lowestID; } stock int GetSurvivorType(const char[] modelName) { if(StrContains(modelName,"biker",false) > -1) { return 6; }else if(StrContains(modelName,"teenangst",false) > -1) { return 5; }else if(StrContains(modelName,"namvet",false) > -1) { return 4; }else if(StrContains(modelName,"manager",false) > -1) { return 7; }else if(StrContains(modelName,"coach",false) > -1) { return 2; }else if(StrContains(modelName,"producer",false) > -1) { return 1; }else if(StrContains(modelName,"gambler",false) > -1) { return 0; }else if(StrContains(modelName,"mechanic",false) > -1) { return 3; }else{ return false; } }